Don't error out on undefined options #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuSh
force-pushed
the
patch-1
branch
2 times, most recently
from
db8d92b to
4fda24e
Compare
KuSh
force-pushed
the
patch-1
branch
3 times, most recently
from
d7fcde9 to
6ae9c41
Compare
iamart
approved these changes
May 15, 2024
|
Wondering why those tests were even created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allow calling sign with undefined options without erroring out
Fixes #703
Checklist
I have added documentation for new/changed functionality in this PR or in auth0.com/docsN/Amaster